chore: support sharding component hscale to rerender #8821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8821 +/- ##
==========================================
- Coverage 60.34% 60.26% -0.09%
==========================================
Files 381 381
Lines 46215 46244 +29
==========================================
- Hits 27889 27868 -21
- Misses 15654 15701 +47
- Partials 2672 2675 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zjx20
approved these changes
Jan 20, 2025
Y-Rookie
reviewed
Jan 21, 2025
| @@ -207,12 +207,13 @@ type ComponentConfigSpec struct { | |||
|
|
|||
| // RerenderResourceType defines the resource requirements for a component. | |||
| // +enum | |||
| // +kubebuilder:validation:Enum={vscale,hscale,tls} | |||
| // +kubebuilder:validation:Enum={vscale,hscale,tls,shardingHScale} | |||
There was a problem hiding this comment.
how about supporting shardingVScale together?
Y-Rookie
reviewed
Jan 21, 2025
| return nil | ||
| } | ||
|
|
||
| clusterCompName := component.Labels[constant.KBAppShardingNameLabelKey] |
There was a problem hiding this comment.
rename clusterCompName -> shardingName would be better
Y-Rookie
reviewed
Jan 21, 2025
| return nil | ||
| } | ||
|
|
||
| for i, comp := range cluster.Spec.Shardings { |
There was a problem hiding this comment.
ditto, rename comp -> sharding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.